New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deviate the testing::read implementation from testing::create #18

Merged

mara-schulke merged 1 commit into main from mara/testing

Jun 29, 2024

Contributor

mara-schulke commented Feb 26, 2024

Make use of find_all when running atmosphere::testing::read

mara-schulke requested a review from cdbrkfxrpt

February 26, 2024 18:27

mara-schulke self-assigned this

mara-schulke enabled auto-merge (squash)

March 15, 2024 10:53


          Make use of find_all in the read test

82b971c

cdbrkfxrpt force-pushed the mara/testing branch from 5ee70d9 to 82b971c Compare

June 29, 2024 11:43

cdbrkfxrpt approved these changes

View reviewed changes

Contributor

cdbrkfxrpt left a comment

I still think the tests need more work but let's merge this for now; it's a step in the right direction.

mara-schulke merged commit c09c310 into main

3 of 4 checks passed

mara-schulke deleted the mara/testing branch

June 29, 2024 11:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet