Sorted build issue and warnings

helsenorge · Jul 3, 2024 · 62c3d6d · 62c3d6d
1 parent 11d0895
commit 62c3d6d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Directory.build.props b/Directory.build.props
@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <LangVersion>10.0</LangVersion>
-    <Version>5.2.0-beta03</Version>
+    <Version>5.2.0-beta04</Version>
   </PropertyGroup>
   <PropertyGroup>
     <Authors>Norsk Helsenett SF</Authors>

diff --git a/src/Helsenorge.Registries/AddressRegistryRest.cs b/src/Helsenorge.Registries/AddressRegistryRest.cs
@@ -197,41 +197,47 @@ public async Task<CertificateDetails> GetCertificateDetailsForEncryptionAsync(in
         [Obsolete("This method is no longer supported.")]
         public async Task<CertificateDetails> GetCertificateDetailsForEncryptionAsync(int herId, bool forceUpdate)
         {
+            await Task.Yield(); // Dummy await to avoid warning
             throw new NotImplementedException();
         }
 
         /// <inheritdoc cref="IAddressRegistry.GetCertificateDetailsForValidatingSignatureAsync(int)"/>
         [Obsolete("This method is no longer supported.")]
         public async Task<CertificateDetails> GetCertificateDetailsForValidatingSignatureAsync(int herId)
         {
+            await Task.Yield(); // Dummy await to avoid warning
             throw new NotImplementedException();
         }
 
         /// <inheritdoc cref="IAddressRegistry.GetCertificateDetailsForValidatingSignatureAsync(int, bool)"/>
         [Obsolete("This method is no longer supported.")]
         public async Task<CertificateDetails> GetCertificateDetailsForValidatingSignatureAsync(int herId, bool forceUpdate)
         {
+            await Task.Yield(); // Dummy await to avoid warning
             throw new NotImplementedException();
         }
 
         /// <inheritdoc cref="IAddressRegistry.SearchByIdAsync"/>/>
         [Obsolete("This method is no longer supported.")]
         public async Task<IEnumerable<CommunicationPartyDetails>> SearchByIdAsync(string id, bool forceUpdate = false)
         {
+            await Task.Yield(); // Dummy await to avoid warning
             throw new NotImplementedException();
         }
 
         /// <inheritdoc cref="IAddressRegistry.GetOrganizationDetailsAsync"/>
         [Obsolete("This method is no longer supported.")]
         public async Task<OrganizationDetails> GetOrganizationDetailsAsync(int herId, bool forceUpdate = false)
         {
+            await Task.Yield(); // Dummy await to avoid warning
             throw new NotImplementedException();
         }
 
         /// <inheritdoc cref="IAddressRegistry.PingAsync"/>
         [Obsolete("This method is no longer supported.")]
         public async Task PingAsync()
         {
+            await Task.Yield(); // Dummy await to avoid warning
             throw new NotImplementedException();
         }
     }

diff --git a/src/Helsenorge.Registries/CollaborationProtocolRegistryRest.cs b/src/Helsenorge.Registries/CollaborationProtocolRegistryRest.cs
@@ -65,7 +65,7 @@ public CollaborationProtocolRegistryRest(
 
         var httpClientFactory = new ProxyHttpClientFactory(settings.RestConfiguration);
         _restServiceInvoker = new RestServiceInvoker(_logger, httpClientFactory);
-        CertificateValidator = new CertificateValidator(_settings.UseOnlineRevocationCheck);
+        CertificateValidator = new CertificateValidator(_logger, _settings.UseOnlineRevocationCheck);
     }
 
     /// <inheritdoc cref="FindProtocolForCounterpartyAsync"/>