-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unit tests compatible with NumPy 2.x #1826
Open
Marc-Jindra
wants to merge
14
commits into
main
Choose a base branch
from
1552-Make_unit_tests_compatible_with_NumPy_2_x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−25
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
31d7718
changed row_stack to vstack for numpy >= 2.0.0
Marc-Jindra 6d4a02a
Merge branch 'main' into 1552-Make_unit_tests_compatible_with_NumPy_2_x
Marc-Jindra 4b4f61b
Changed the numpy version check to the numpy suggested method
Marc-Jindra 6993b00
Changed numpy version requirement
Marc-Jindra a0f4b25
fixed DeprecationWarning from missing axes for np.fft.fftn
Marc-Jindra cf02582
Fixed one __array_wrap__ DeprecationWarning
Marc-Jindra 4b68291
Merge branch 'main' into 1552-Make_unit_tests_compatible_with_NumPy_2_x
Marc-Jindra d603589
Stopped testing cross of vector axes with 2 elements for numpy >= 2.0
Marc-Jindra f4d366d
changed requirements to avoid errors with numpy >= 2
Marc-Jindra 89ee3e8
Using Python 3.10 for RecievePR
Marc-Jindra 82f64e1
changed python-version to '3.10' because 3.10 was interpreted as 3.1
Marc-Jindra 238c31f
changed ci.yaml to exclude python 3.9
Marc-Jindra 628d031
Merge branch 'main' into 1552-Make_unit_tests_compatible_with_NumPy_2_x
Marc-Jindra be4d874
Merge branch 'main' into 1552-Make_unit_tests_compatible_with_NumPy_2_x
mrfh92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,6 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
py-version: | ||
- 3.9 | ||
- '3.10' | ||
- 3.11 | ||
- 3.12 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,10 +21,9 @@ | |
author_email="[email protected]", | ||
url="https://github.com/helmholtz-analytics/heat", | ||
keywords=["data", "analytics", "tensors", "distributed", "gpu"], | ||
python_requires=">=3.9", | ||
python_requires=">=3.10", | ||
classifiers=[ | ||
"Development Status :: 4 - Beta", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
|
@@ -34,9 +33,9 @@ | |
], | ||
install_requires=[ | ||
"mpi4py>=3.0.0", | ||
"numpy>=1.22.0, <2", | ||
"numpy>=1.23.5", | ||
"torch>=2.0.0, <2.6.1", | ||
"scipy>=1.10.0", | ||
"scipy>=1.14.0", | ||
"pillow>=6.0.0", | ||
"torchvision>=0.15.2, <0.21.1", | ||
], | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marc-Jindra During the PR meeting this morning we decided to keep the "cross_2d" functionality in Heat for now and compare it to the pytorch result in the tests when numpy==2. I.e. compare the distributed
ht.cross
(on split arrays) with the non-distributed pytorch output.