This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Update to latest image, add OWNERS as well as add new owner to team, … #10107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/M
|
/assign @unguiculus - when you have a moment, minor tweaks but more importantly trying to the OWNERS process setup so we can help manage the chart. |
|
/assign @unguiculus |
darend
approved these changes
Dec 18, 2018
helm-bot
added
size/M
…fix README, update Helm Charts root readme with incorrect text. Signed-off-by: Frank Reno [email protected] Signed-off-by: Frank Reno <[email protected]>
helm-bot
added
Contribution Allowed
…by: Frank Reno [email protected] Signed-off-by: Frank Reno <[email protected]>
helm-bot
added
Contribution Allowed
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frankreno, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
coreypobrien
pushed a commit
to FairwindsOps/helm-charts
that referenced
this pull request
Dec 31, 2018
helm#10107) * Update to latest image, add OWNERS as well as add new owner to team, fix README, update Helm Charts root readme with incorrect text. Signed-off-by: Frank Reno [email protected] Signed-off-by: Frank Reno <[email protected]> * add delete policy hook to fix issues when upgrading chart Signed-off-by: Frank Reno [email protected] Signed-off-by: Frank Reno <[email protected]>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
helm#10107) * Update to latest image, add OWNERS as well as add new owner to team, fix README, update Helm Charts root readme with incorrect text. Signed-off-by: Frank Reno [email protected] Signed-off-by: Frank Reno <[email protected]> * add delete policy hook to fix issues when upgrading chart Signed-off-by: Frank Reno [email protected] Signed-off-by: Frank Reno <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fix README, update Helm Charts root readme with incorrect text.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Please let me know next steps on the OWNERS file set up so we have permission to maintain the chart going forward and if you need anything else. (cc @darend @flah00 FYI)
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]