Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendoring. test stil fail though #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vendoring. test stil fail though #2

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2017

do you want to vendor this.
the vendored files are not committed, just the manifest

@heralight
Copy link
Contributor

Thank you for your help.
But, before add vendor dependencies on this library, is convention to not vendor dependencies for libraries as changed for golang?
If you have any new information on that, I will add your push (I love this idea ;).

https://peter.bourgon.org/go-best-practices-2016/#dependency-management
https://www.reddit.com/r/golang/comments/4cptba/best_practice_for_vendoring_in_libraries/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heralight @gedw99