-
Notifications
You must be signed in to change notification settings - Fork 184
Add support for macOS. #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can you provide details on how you managed to build directx-dxc? |
I cloned DirectXShaderCompiler and built it like so:
|
This error keeps coming CMake Error at tools/XenosRecomp/XenosRecomp/CMakeLists.txt:22 (find_package):
Could not find a package configuration file provided by "directx-dxc" with
any of the following names:
directx-dxcConfig.cmake
directx-dxc-config.cmake
Add the installation prefix of "directx-dxc" to CMAKE_PREFIX_PATH or set
"directx-dxc_DIR" to a directory containing one of the above files. If
"directx-dxc" provides a separate development package or SDK, be sure it
has been installed. |
After you build |
Exactly what I did. I'm probably missing something |
Current status: With everything here and in linked PRs in the original post, along with a build of latest MoltenVK and a fixed SPIRV-Cross, able to get fully working ARM Debug/RelWithDebInfo builds. Release builds still have an issue causing crash on game start that I need to look into. |
Hi @squidbus, where can I get the fixed SPIRV-Cross from? I am building from the latest commit on the main branch and am getting the following error when trying to load files:
|
|
Still will need some other PR merges to be ready but should be able to build and run this without modifications now. |
I can confirm. |
I was able to get in game, and play until the loop in the first level. Some of the first few cutscenes are a bit choppy, but it's more smooth during gameplay. After that, it crashes with a EXC_BAD_ACCESS. |
@squidbus @Yash-Singh1 |
Thank you so much for your hard work in fixing the game for M1/M2, it works great now! However, I have another bug to report. I recently upgraded to an M4 Air, and on the laptop screen itself, I'm very pleased with how the improved CPU/GPU can run Sonic Unleashed. When I plugged into my external monitor, though... I know the M4 is capable of more, especially at a lower resolution than the internal display. So I don't know why the framerate is dipping so much. I'm connected to a 1080p display through HDMI via a USB-C hub. My M1 never had this issue. I even set the graphics settings to what made the M1 hit 60 FPS consistently and disabled all mods, but it still maintained sub-30 FPS. The Terminal log didn't show anything abnormal, either. |
Are you on the latest Unleashed Recomp version? Do you still have this issue? |
Yes and yes. The performance actually has gotten a bit worse since my last reboot, yet it still speeds up whenever I am screen recording. I must emphasize--this only happens with my EXTERNAL display. For some reason, it runs flawlessly when disconnected and using the internal display. I'm using an M4 MacBook Air with the 10-core GPU running macOS 15.4.1 (the latest version as of this comment). |
This sounds like an issue with the Monitor or HDMI/Usb C hub. Does your cable support HDMI 2.0 or 2.1? Some older cables can't handle 1080p 60 fps. Also what Usb C hub are you using? Some only support HDMI 1.4, which could limit you to 30 FPS. The cable or hub could be bottlenecking your performance. You should also check the refresh rate and resolution of your monitor, if it's 60hz we know it's not the monitor.
|
Have you tried turning off game mode when macOS automatically turns it on |
Performance is the same whether Game Mode is on or off. |
Okay, second question: have you tried windowed mode? |
Just tried it, and it helps a little bit. The performance is a bit better but it still dips every now and then. The frame rate also still locks at either 30 or 60. |
Hi! It's looking like these builds are really solid, working well in my tests. What's left before it can be merged and part of an official release? Anything we can help with? |
It's just waiting for someone to have time to review. |
Took a very quick look. No huge changes in any single file, which will help. Does the Edit: same question for the |
Those submodules are waiting on changes being merged to main as well. And by review I meant from the maintainers of this project. |
The PRs are 100% going to be merged, I'm just taking a break from this project for a bit, so the reviews will take a while. |
@blueskythlikesclouds no worries at all, we have working builds, there is absolutely no rush, hope you’re enjoying your downtime. Thanks for coming back to respond. Appreciate everyone’s work to get it this far. |
Did some MoltenVK updates and have the latest build here: https://github.com/squidbus/UnleashedRecomp/actions/runs/15078018461 Would ask that anyone who had frame rate issues test again, I don't seem to have any with this current build. |
Also if you do have frame rate issues still, it could be useful to open the profiler graph with F1 and send a screenshot of the graph and the time numbers below it. |
Adds working macOS support.