Skip to content

CI GitHub Action PR Fix #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AL2009man
Copy link
Contributor

@AL2009man AL2009man commented May 1, 2025

This is a poor man's attempt on addressing GitHub Action doesn't respect Pull Requests and it's branches while validating. #1311

As this simple change might break GitHub Actions in the process, serious verification will be needed first. For now: this will be a Draft PR.

@squidbus
Copy link
Contributor

squidbus commented May 1, 2025

I think the issue here is simply that this repository is using pull_request_target instead of pull_request as the action trigger. Although maybe that is needed because of the private repo, so I guess that's why this workaround is needed here.

@AL2009man AL2009man marked this pull request as ready for review May 19, 2025 22:57
@AL2009man
Copy link
Contributor Author

I think the issue here is simply that this repository is using pull_request_target instead of pull_request as the action trigger. Although maybe that is needed because of the private repo, so I guess that's why this workaround is needed here.

hm...I'm going to open this PR for review, if anyone wanna look into it. unfortunately, I can't fully test nor verify myself til then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants