Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto equip #699

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Auto equip #699

wants to merge 15 commits into from

Conversation

CarlPoppa1
Copy link

@CarlPoppa1 CarlPoppa1 commented Feb 25, 2025

Heavily borrowed from kolbot-soloplay
This only supports softcore sorc with an act 2 merc.

Known issues:

  • After equipping a ring, it immediately tries to equip the same ring in the other ring slot
  • No inventory space checks when swapping items of different sizes in left and right arm
  • Some stats aren't being read (e.g Decrepify on hit on Reapers Toll)

To do:

  • Add other breakpoints (FCR, FHR etc) and check if replacing an item with FCR or FHR for one with an item without (or an item with less FCR, FHR) will drop past a breakpoint.
  • Add handling of equippable quest items in D2Go
  • Add the +x in +x to skills. Currently it just adds a flat value if there is a relevant +x to skills. It should multiply the weighting by the +x. So if the weighting is 40, +3 to Blizzard should add 120 to the item score, it currently only adds 40 to the score.

@CarlPoppa1 CarlPoppa1 marked this pull request as draft February 25, 2025 15:18
@artosimonyan
Copy link
Collaborator

@CarlPoppa1,

This definitely needs to be an option that can be enabled, not turned on at all times.

@CarlPoppa1
Copy link
Author

@CarlPoppa1,

This definitely needs to be an option that can be enabled, not turned on at all times.

Definitely, I should have done that before raising the PR. Added here b428b0e

@artosimonyan
Copy link
Collaborator

@CarlPoppa1 Not a setting in the auto leveling script, but in the bot's settings. We can use the auto equip on newly leveled charms that just start to farm gear.

Add it as a main setting.

@CarlPoppa1
Copy link
Author

@CarlPoppa1 Not a setting in the auto leveling script, but in the bot's settings. We can use the auto equip on newly leveled charms that just start to farm gear.

Add it as a main setting.

I'll need to do more work if that's how it's going to be implemented. Currently it won't work well for melee chars because it's forcing only a shield to be equipped in the right arm slot so barbs and assassins won't ever dual wield. I'll add it as a main setting once I've tested it on other supported classes apart from sorc

@Wamlad
Copy link

Wamlad commented Mar 9, 2025

This is working pretty well so far, thanks for making it.
The main issue I have is it switches weapons to far worse items. I've noticed a recurrance of weapons with single resists on them like +7 cold resist, +9 fire resist etc. So not sure if that's a coincidence or the route cause is related to the resists score.
I'm running fire levling sorc and mostly have the leaf runeword equipped. So that's the other place the issue could be (without any proper code review).
I haven't had the chance to test or add debug logs to check why it's happening sorry, but thought I'd comment in case you or others have this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants