Fix seals, prevent issue with koolo closing entirely (crash) #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent bot from teleporting up to 5 time on seals before interacting. change to ClearThroughpath : Increasing step.MoveTo(dest, step.WithDistanceToFinish(7) as option prevent not being to able to finish movement if our destination is center of a large object like Seal in diablo run. is used only for pathing, attack.go or pathfinder will use default DistanceToFinishMoving (4) . Change to interaction.go : Is similar to solution from ClearThroughPath : if InteractObject with a Seal, we increase DistanceToFinish so it will consider in range at this distance. With default 4 it wont be able to reach destination and bounce back on seal since its further then 4 and we dont pass to step.InteractObject until we are in range.
Proper cleanup of checkMonsterDamage to prevent Koolo from closing(crashing) with random fatal error.
We dont need retry mechanism here, High priority loop will automatically retry shortly after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seals:
Prevent bot from teleporting up to 5 time on seals before interacting.
change to ClearThroughpath :
Increasing step.MoveTo(dest, step.WithDistanceToFinish(7) as option prevent not being to able to finish movement if our destination is center of a large object like Seal in diablo run. is used only for pathing, attack.go or pathfinder will use default DistanceToFinishMoving (4) .
Change to interaction.go :
Is similar to solution from ClearThroughPath :
if InteractObject with a Seal, we increase DistanceToFinish so it will consider in range at this distance. With default 4 it wont be able to reach destination and bounce back on seal since its further then 4 and we dont pass to step.InteractObject until we are in range.
Koolo crash
Proper cleanup of checkMonsterDamage to prevent Koolo from closing(crashing) with random fatal error.
code cleanup
We dont need retry mechanism here, High priority loop will automatically retry shortly after