Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional vendor check for keys and scrolls #628

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

sorc653
Copy link
Contributor

@sorc653 sorc653 commented Jan 15, 2025

The vendor selected for each act doesn't always have keys or scrolls, so we have to go to another vendor to do so.

This PR adds an additional check for purchasing keys and scrolls to ensure we don't run out. It also adds an option to return to town if we run out of keys. And it will only pick up keys if that option is enabled, or they already had some keys (but less than 12) in their inventory. It will not pickup more to put us over one stack.

Specific scenarios this fixes:

  1. Act 2 scrolls will run out and not be re-purchased
  2. Act 3 keys will run out and not be re-purchased

Interface change:

Screenshot 2025-02-03 at 2 12 35 PM

@sorc653 sorc653 force-pushed the additional-check-for-scrolls branch 3 times, most recently from b278aa9 to 4136282 Compare January 15, 2025 20:59
@sorc653 sorc653 force-pushed the additional-check-for-scrolls branch from 4136282 to c7bded4 Compare January 15, 2025 21:32
@elobo91
Copy link
Contributor

elobo91 commented Jan 26, 2025

Hello, could you add keys to item_pickup in shouldbepickedup . Keys drop often from chests and it prevent going to town for nothing while it can sustain with drops. You will need to check stack quantity on ground if it fits stack in inventory ( max 12) . Key drop can be 1-2-3-4 key stacks . We cant use .nip for that as it wouldnt respect max key count and make multiple stack. Buying at vendor when 1 key left( tp to town to refill) For scrolls vendor is totally fine. Pr look good otherwise thanks

@sorc653
Copy link
Contributor Author

sorc653 commented Jan 28, 2025

Hello, could you add keys to item_pickup in shouldbepickedup . Keys drop often from chests and it prevent going to town for nothing while it can sustain with drops. You will need to check stack quantity on ground if it fits stack in inventory ( max 12) . Key drop can be 1-2-3-4 key stacks . We cant use .nip for that as it wouldnt respect max key count and make multiple stack. Buying at vendor when 1 key left( tp to town to refill) For scrolls vendor is totally fine. Pr look good otherwise thanks

Change complete!

@sorc653 sorc653 force-pushed the additional-check-for-scrolls branch from 39441ba to 7f189ea Compare January 28, 2025 21:24
@sorc653
Copy link
Contributor Author

sorc653 commented Feb 3, 2025

Don't merge yet, going to have it only pick up keys if you are opening chests.

@sorc653 sorc653 requested a review from hectorgimenez February 3, 2025 19:27
@sorc653
Copy link
Contributor Author

sorc653 commented Feb 3, 2025

Ready for merge!

@artosimonyan artosimonyan merged commit 0d0efd6 into hectorgimenez:main Feb 6, 2025
1 check passed
@sorc653 sorc653 deleted the additional-check-for-scrolls branch February 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants