Added cube recipes for gems (and renamed recipes for upgrading) #535
+148
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Cube recipes for upgrading gems from chipped to perfect, renamed gem recipes to match the rune recipes (upgrade ...)
Renamed existing recipes, added recipes for gems to match the recipes for runes (Upgrade ...) Crafting recipes are available within cubing_recipes.go but were missing here. Not sure if this was/is intentional, added them for the sake of completeness. => is it intended to hide those recipes?
|
Still not sure about this one. It will make the settings UI hideous with all those recipes. Also, not sure about the naming convention yet (if it should be mixed, same or w/e). Have to think about it |
Could do with some cleanup, but having those recipes is a step forward. As for the UI concern, we could just rework the UI with some collapsing menus or something, but I think @hectorgimenez is already working on something. |
|
I've added this to my dev branch and there is no issue. Blood gauntlets get crafted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the missing recipes for upgrading all gems from chipped to perfect gems.
Renamed the recipes for gems to match the terminology of runes (Upgrading ...), so far the naming has been contradictory.
Crafting recipes are available within cubing_recipes.go but were missing in recipes.go.
Not sure if this was/is intentional, added them for the sake of completeness.
=> is it intended to hide those recipes? If no the comment // could be deleted to activate the recipes.
@maintainers: feel free to edit the file if needed