Skip to content

Filter out erratic scrollwheel events #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ligenxxxx merged 2 commits into from
Jan 24, 2026
Merged

Filter out erratic scrollwheel events #590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c02a56
Filter out erratic scrollwheel events
RaceMiata Jan 18, 2026
2cc192a
Filter out direction change events
RaceMiata Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 47 additions & 21 deletions src/core/input_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <string.h>
#include <sys/epoll.h>
#include <sys/stat.h>
#include <sys/time.h>
#include <unistd.h>

#include <log/log.h>
Expand Down Expand Up @@ -453,28 +454,44 @@ static void get_event(int fd) {

static int roller_value = 0;

// time (sec, usec) difference above which will the next scroll wheel event be accepted
// 10000 usec = 10msec is more than short enough (100Hz)
// scroll events
const struct timeval scroll_time_diff = {0, 10000};
// direction change events
const struct timeval rel_time_diff = {0, 20000};
// expected timestamp in the future beyond that will the events be accepted
static struct timeval next_scroll = {0, 0};
static struct timeval next_rel = {0, 0};
static bool discard_scroll = false;

read(fd, &event, sizeof(event));

switch (event.type) {
case EV_SYN:
if (event.code == SYN_REPORT) {
if (event_type_last == EV_REL) {
if (roller_value == 1) {
roller_up_acc++;
roller_down_acc = 0;
} else if (roller_value == -1) {
roller_down_acc++;
roller_up_acc = 0;
}
if (!discard_scroll && timercmp(&event.time, &next_scroll, >)) {
timeradd(&event.time, &scroll_time_diff, &next_scroll);
if (roller_value == 1) {
roller_up_acc++;
roller_down_acc = 0;
} else if (roller_value == -1) {
roller_down_acc++;
roller_up_acc = 0;
}

if (roller_up_acc == DIAL_SENSITIVITY) {
roller_up();
g_key = DIAL_KEY_UP;
roller_up_acc = 0;
} else if (roller_down_acc == DIAL_SENSITIVITY) {
roller_down();
g_key = DIAL_KEY_DOWN;
roller_down_acc = 0;
if (roller_up_acc == DIAL_SENSITIVITY) {
roller_up();
g_key = DIAL_KEY_UP;
roller_up_acc = 0;
} else if (roller_down_acc == DIAL_SENSITIVITY) {
roller_down();
g_key = DIAL_KEY_DOWN;
roller_down_acc = 0;
}
} else {
// LOGI("discard EV_SYN");
}
} else if (event_type_last == EV_KEY) {
if (btn_value) {
Expand Down Expand Up @@ -518,13 +535,22 @@ static void get_event(int fd) {
}
break;
case EV_REL:
if (event.code == REL_X) {
// LOGI("x = %d", event.value);
} else if (event.code == REL_Y) {
roller_value = event.value;
// LOGI("y = %d", event.value);
if (timercmp(&event.time, &next_rel, >)) {
discard_scroll = false;
if (event.code == REL_X) {
// LOGI("x = %d", event.value);
} else if (event.code == REL_Y) {
if (roller_value != event.value) {
timeradd(&event.time, &rel_time_diff, &next_rel);
roller_value = event.value;
// LOGI("y = %d", event.value);
}
event_type_last = EV_REL;
}
} else {
discard_scroll = true;
LOGI("discard EV_REL");
}
event_type_last = EV_REL;
break;
default:
// LOGI("unknown [type=%d, code=%d value=%d]", event.type, event.code, event.value);
Expand Down