Security and performance improvements on authentication #5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Makarov Sergey <[email protected]>
…nto features/security-improvement
…d to async Signed-off-by: Makarov Sergey <[email protected]>
Signed-off-by: Makarov Sergey <[email protected]>
…nto features/security-improvement
|
@lexiv0re Please check if this is valid for new global account and use proposed changes, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
pbkdf2Sync from 'node:crypto' was changed to callback version - pbkdf2
Buffer.compare() replaced with timingSafeEqual() from 'node:crypto'
*The crypto.timingSafeEqual() function is used to determine whether two variables are equal without exposing timing information that may allow an attacker to guess one of the values. A constant-time algorithm underpins it.
hashWithSalt() function was promisified and renamed to 'hashPassword'
verifyPassword() function was promisified
try...catch blocks added in places where functions are called
Signed-off-by: Makarov Sergey [email protected]