Document local build/test steps in contributing.md#48
Open
anagnorisis2peripeteia wants to merge 1 commit into
Open
Document local build/test steps in contributing.md#48anagnorisis2peripeteia wants to merge 1 commit into
anagnorisis2peripeteia wants to merge 1 commit into
Conversation
Add a 'Before opening a pull request' section with the exact build + test commands (matching ci-build.yml) and a note about the three known-failing snapshot tests, so new contributors know what to run and aren't tripped up by the pre-existing fixture failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Before opening a pull request" section to
contributing.mdwith the exactbuild + test commands (mirroring
.github/workflows/ci-build.yml), so new contributorsknow what to run locally before submitting.
It also notes that three serialization snapshot tests (
CheckSettingsSave,CheckWriteProfile,CheckJaysProfileRead) fail on a clean checkout (stale expected-XMLfixtures) and are skipped by CI's
--filter, so contributors aren't tripped up by thosepre-existing failures.
Docs-only; no code change.
Authored with Claude (Opus 4.8).