Remove handled fragmented messages from the map #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verify |
We should remove handled fragmented messages from fragmentedMessages map to free it up. This PR includes this fix. Also, FragmentedClientMessageHandlerTest is enhanced to check the the map's size before and after merging and handling the end fragment.
mdumandag
force-pushed
the
remove-fragmented-messages
branch
from
3db56dc to
b2acfe2
Compare
|
Thanks for the review Andrey, I am merging this. |
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* Remove handled fragmented messages from the map We should remove handled fragmented messages from fragmentedMessages map to free it up. This PR includes this fix. Also, FragmentedClientMessageHandlerTest is enhanced to check the the map's size before and after merging and handling the end fragment. * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #568 (because of CI build changes)
We should remove handled fragmented messages from fragmentedMessages
map to free it up. This PR includes this fix.
Also, FragmentedClientMessageHandlerTest is enhanced to check the
the map's size before and after merging and handling the
end fragment.