-
Notifications
You must be signed in to change notification settings - Fork 13
New search experience #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for lucid-bassi-1dc305 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments and suggestions - it's looking very good...
I know you're still waiting on designs but are we intending to include promoting and improving the positioning of Ask AI button generally in this PR?
src/partials/algolia-search.hbs
Outdated
</a>`; | ||
}, | ||
noResults({ html }) { | ||
return html`<p class="search-no-results">No results found.</p>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we position and style this within window better? Compare to Algolia own search where they centre the text and make it bigger. Also:
return html`<p class="search-no-results">No results found.</p>`; | |
return html`<p class="search-no-results">No results found for ${state.query}. You could try expanding your search terms or asking AI...</p>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I like this - thanks
Co-authored-by: Oliver Howell <[email protected]>
Let's do it in a separate PR |
indexPrefix: "_test_", | ||
rateLimit: 10, | ||
maxUrls: 40, | ||
schedule: "on the first day of the month", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we update the schedule to be more regular once we switch over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, how often do you want it to happen?
No description provided.