Skip to content

Conversation

fantkolja
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for lucid-bassi-1dc305 ready!

Name Link
🔨 Latest commit 997bdc8
🔍 Latest deploy log https://app.netlify.com/projects/lucid-bassi-1dc305/deploys/68adb8ff8eac2d00080102b8
😎 Deploy Preview https://deploy-preview-272--lucid-bassi-1dc305.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fantkolja fantkolja changed the title Ids for the crawler New search experience Aug 11, 2025
@fantkolja fantkolja marked this pull request as ready for review August 22, 2025 11:29
@fantkolja fantkolja requested a review from a team as a code owner August 22, 2025 11:29
Copy link
Collaborator

@oliverhowell oliverhowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and suggestions - it's looking very good...

I know you're still waiting on designs but are we intending to include promoting and improving the positioning of Ask AI button generally in this PR?

</a>`;
},
noResults({ html }) {
return html`<p class="search-no-results">No results found.</p>`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we position and style this within window better? Compare to Algolia own search where they centre the text and make it bigger. Also:

Suggested change
return html`<p class="search-no-results">No results found.</p>`;
return html`<p class="search-no-results">No results found for ${state.query}. You could try expanding your search terms or asking AI...</p>`;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like this - thanks

@fantkolja
Copy link
Collaborator Author

Minor comments and suggestions - it's looking very good...

I know you're still waiting on designs but are we intending to include promoting and improving the positioning of Ask AI button generally in this PR?

Let's do it in a separate PR

indexPrefix: "_test_",
rateLimit: 10,
maxUrls: 40,
schedule: "on the first day of the month",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we update the schedule to be more regular once we switch over?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, how often do you want it to happen?

@fantkolja fantkolja requested a review from oliverhowell August 26, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants