osal/none: add nested count to spin lock #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds nested locking support to the bare-metal spinlock implementation in osal_none.h. The enhancement allows the same execution context to acquire a spinlock multiple times without deadlocking, which is crucial for single-core bare-metal systems where nested critical sections are common.
Key changes:
- Added
nested_countfield to track lock depth and prevent premature interrupt re-enabling - Modified lock/unlock logic to only disable/enable interrupts on the outermost lock/unlock
- Added underflow detection to catch mismatched lock/unlock pairs
Signed-off-by: HiFiPhile <[email protected]>
hathach
reviewed
Nov 19, 2025
| TU_ATTR_ALWAYS_INLINE static inline void osal_spin_unlock(osal_spinlock_t *ctx, bool in_isr) { | ||
| if (!in_isr) { | ||
| // Check for underflow - unlock without lock | ||
| if (ctx->nested_count == 0) { |
Owner
There was a problem hiding this comment.
let make it simpler, in case of 0, we just return since the spin is not locked to begin with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
To allow it be used in nested functions, I think most OSs already have the counter.