Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR removes deprecated concurrency-strategy symbols, reserves their protobuf identifiers, and fills omissions for newer strategies in frontend and generated TypeScript enums.
Confidence Score: 4/5The PR appears safe to merge after addressing the non-blocking generated-contract consistency and SDK release-metadata issues. The active v1 concurrency path supports the new strategies, but the legacy generated TypeScript enum additions will be lost on regeneration and do not round-trip through its JSON helpers; the Python and TypeScript SDK changes also lack required version and changelog updates. Files Needing Attention: sdks/typescript/src/protoc/workflows/workflows.ts, api-contracts/workflows/workflows.proto, sdks/python/hatchet_sdk/types/concurrency.py Reviews (1): Last reviewed commit: "initial commit" | Re-trigger Greptile |
| CANCEL_IN_PROGRESS = "CANCEL_IN_PROGRESS" | ||
| GROUP_ROUND_ROBIN = "GROUP_ROUND_ROBIN" | ||
| CANCEL_NEWEST = "CANCEL_NEWEST" | ||
| QUEUE_NEWEST = "QUEUE_NEWEST" | ||
| QUEUE_OLDEST = "QUEUE_OLDEST" | ||
| CANCEL_QUEUED_EXCEPT_NEWEST = "CANCEL_QUEUED_EXCEPT_NEWEST" |
There was a problem hiding this comment.
These Python and TypeScript SDK contract changes have no corresponding version bumps or changelog entries, so the removed and added public enum members can ship without the repository-required package versions and migration records.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| CANCEL_QUEUED_EXCEPT_NEWEST = 5, | ||
| CANCEL_QUEUED_EXCEPT_OLDEST = 6, |
There was a problem hiding this comment.
|
|
Description
Deprecated concurrency strategies were accidentally added, removed them. Also deleted from the proto. Fixed a few issues in FE where the new concurrency strategies were not added to some switch statements.
Fixes # (issue)
Type of change
Checklist
Changes have been:
🤖 AI Disclosure