Skip to content

fix: Cleanup deprecated concurrency strategies, fix FE omissions - #4883

Open
juliusgeo wants to merge 3 commits into
mainfrom
cleanup_conc_strats
Open

juliusgeo wants to merge 3 commits into
mainfrom
cleanup_conc_strats

Conversation

@juliusgeo

Copy link
Copy Markdown
Contributor

Description

Deprecated concurrency strategies were accidentally added, removed them. Also deleted from the proto. Fixed a few issues in FE where the new concurrency strategies were not added to some switch statements.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change (pure documentation change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking changes to code which doesn't change any behaviour)
  • Performance improvement (non-breaking change which improves performance)
  • CI (any automation pipeline changes)
  • Chore (changes which are not directly related to any business logic)
  • Test changes (add, refactor, improve or change a test)
  • This change requires a documentation update

Checklist

Changes have been:

  • Documented (where applicable)
  • Added to CHANGELOG (where applicable) -- see Keep a Changelog

🤖 AI Disclosure
  • I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
  • Details: [e.g. generating tests, writing docs]

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hatchet-docs Ready Ready Preview Sep 3, 2026 5:15pm UTC

Request Review

@github-actions github-actions Bot added sdk-ts Related to the Typescript SDK sdk-go Related to the Go SDK sdk-py Related to the Python sdk engine Related to the core Hatchet engine dashboard Related to the Hatchet dashboard labels Sep 3, 2026
@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes deprecated concurrency-strategy symbols, reserves their protobuf identifiers, and fills omissions for newer strategies in frontend and generated TypeScript enums.

  • Updates OpenAPI, protobuf, and generated frontend contracts.
  • Extends workflow settings labels for all current strategies.
  • Removes deprecated Go and Python SDK symbols.
  • Leaves a generated TypeScript enum out of sync with its source protobuf and omits required SDK release metadata.

Confidence Score: 4/5

The PR appears safe to merge after addressing the non-blocking generated-contract consistency and SDK release-metadata issues.

The active v1 concurrency path supports the new strategies, but the legacy generated TypeScript enum additions will be lost on regeneration and do not round-trip through its JSON helpers; the Python and TypeScript SDK changes also lack required version and changelog updates.

Files Needing Attention: sdks/typescript/src/protoc/workflows/workflows.ts, api-contracts/workflows/workflows.proto, sdks/python/hatchet_sdk/types/concurrency.py

Reviews (1): Last reviewed commit: "initial commit" | Re-trigger Greptile

Comment on lines 9 to 12
CANCEL_IN_PROGRESS = "CANCEL_IN_PROGRESS"
GROUP_ROUND_ROBIN = "GROUP_ROUND_ROBIN"
CANCEL_NEWEST = "CANCEL_NEWEST"
QUEUE_NEWEST = "QUEUE_NEWEST"
QUEUE_OLDEST = "QUEUE_OLDEST"
CANCEL_QUEUED_EXCEPT_NEWEST = "CANCEL_QUEUED_EXCEPT_NEWEST"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 SDK release metadata omitted

These Python and TypeScript SDK contract changes have no corresponding version bumps or changelog entries, so the removed and added public enum members can ship without the repository-required package versions and migration records.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +95 to +96
CANCEL_QUEUED_EXCEPT_NEWEST = 5,
CANCEL_QUEUED_EXCEPT_OLDEST = 6,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Generated enum contradicts protobuf

These values are absent from the source protobuf and from this file's JSON conversion cases. Regenerating the binding removes them, while using the current conversion helpers maps them to UNRECOGNIZED instead of preserving the strategy.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ Optional test failure: The load-deadlock job failed on this PR (optimistic-scheduling=true). This check is non-mandatory and does not block merging, but may be worth investigating. View logs

This branch was successfully deployed

1 active deployment
Preview 15e0e0bf Deployed Sep 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Related to the Hatchet dashboard engine Related to the core Hatchet engine sdk-go Related to the Go SDK sdk-py Related to the Python sdk sdk-ruby Related to the Ruby SDK sdk-ts Related to the Typescript SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant