Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QUARKUS ENVs to ndc-connector-oracle #10

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add QUARKUS ENVs to ndc-connector-oracle #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/ndc-connector-oracle/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: v2025.01.14
version: v2025.03.18

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 3 additions & 0 deletions charts/ndc-connector-oracle/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ helm upgrade --install <release-name> \
| `connectorEnvVars.HASURA_SERVICE_TOKEN_SECRET` | Hasura Service Token Secret (Optional) | `""` |
| `connectorEnvVars.JDBC_URL` | The JDBC URL to connect to the database (Required) | `""` |
| `connectorEnvVars.JDBC_SCHEMAS` | A comma-separated list of schemas to include in the metadata (Optional) | `""` |
| `connectorEnvVars.QUARKUS_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT` | Sets the OTLP endpoint to send telemetry data (traces) (Optional) | `""` |
| `connectorEnvVars.QUARKUS_OTEL_EXPORTER_OTLP_METRICS_ENDPOINT` | Sets the OTLP endpoint to send telemetry data (metrics)(Optional) | `""` |
| `connectorEnvVars.QUARKUS_DATASOURCE_JDBC_TRACING` | Enable or disable tracing for JDBC connections (Optional) | `false` |
| `connectorEnvVars.configDirectory` | Connector config directory (See [Enabling git-sync](README.md#enabling-git-sync) when initContainers.gitSync.enabled is set to true) | `"/etc/connector"` |

## Additional Parameters
Expand Down
15 changes: 15 additions & 0 deletions charts/ndc-connector-oracle/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ connectorEnvVars:
HASURA_SERVICE_TOKEN_SECRET: ""
JDBC_URL: ""
JDBC_SCHEMAS: ""
QUARKUS_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT: ""
QUARKUS_OTEL_EXPORTER_OTLP_METRICS_ENDPOINT: ""
QUARKUS_DATASOURCE_JDBC_TRACING: ""
configDirectory: /etc/connector

env: |
Expand All @@ -167,6 +170,18 @@ env: |
- name: JDBC_SCHEMAS
value: {{ .Values.connectorEnvVars.JDBC_SCHEMAS | quote }}
{{- end }}
{{- if .Values.connectorEnvVars.QUARKUS_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT }}
- name: QUARKUS_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
value: {{ .Values.connectorEnvVars.QUARKUS_OTEL_EXPORTER_OTLP_TRACES_ENDPOINT }}
{{- end }}
{{- if .Values.connectorEnvVars.QUARKUS_OTEL_EXPORTER_OTLP_METRICS_ENDPOINT }}
- name: QUARKUS_OTEL_EXPORTER_OTLP_METRICS_ENDPOINT
value: {{ .Values.connectorEnvVars.QUARKUS_OTEL_EXPORTER_OTLP_METRICS_ENDPOINT }}
{{- end }}
{{- if .Values.connectorEnvVars.QUARKUS_DATASOURCE_JDBC_TRACING }}
- name: QUARKUS_DATASOURCE_JDBC_TRACING
value: {{ .Values.connectorEnvVars.QUARKUS_DATASOURCE_JDBC_TRACING }}
{{- end }}
- name: OTEL_EXPORTER_OTLP_ENDPOINT
value: http://localhost:4317
- name: HASURA_CONFIGURATION_DIRECTORY
Expand Down