Fixes

api/src/main/java/pt/haslab/specassistant/data/aggregation/EntityDouble.java

@@ -0,0 +1,5 @@
+package pt.haslab.specassistant.data.aggregation;
+
+public class EntityDouble {
+    public Double d;
+}

api/src/main/java/pt/haslab/specassistant/data/transfer/EntityStringLong.java → api/src/main/java/pt/haslab/specassistant/data/aggregation/EntityStringLong.java

@@ -1,4 +1,4 @@
-package pt.haslab.specassistant.data.transfer;
+package pt.haslab.specassistant.data.aggregation;
 
 public class EntityStringLong {
     public String s;

api/src/main/java/pt/haslab/specassistant/data/models/HintNode.java

@@ -41,8 +41,6 @@ public class HintNode extends PanacheMongoEntity {
 
     public Double score;
 
-    public Double delta;
-
     public HintNode() {
     }
 

api/src/main/java/pt/haslab/specassistant/repositories/HintNodeRepository.java

@@ -4,6 +4,7 @@
 import jakarta.enterprise.context.ApplicationScoped;
 import org.bson.Document;
 import org.bson.types.ObjectId;
+import pt.haslab.specassistant.data.aggregation.EntityDouble;
 import pt.haslab.specassistant.data.models.HintNode;
 import pt.haslab.specassistant.services.policy.Probability;
 import pt.haslab.specassistant.services.policy.Reward;
@@ -147,7 +148,7 @@ public void unsetDelta(ObjectId graph_id) {
         update(new Document("$unset", new Document("delta", null))).where("graph_id", graph_id);
     }
 
-    public Optional<HintNode> getHightestDelta(ObjectId graph_id) {
-        return find(new Document("graph_id", graph_id), new Document("delta", -1)).firstResultOptional();
+    public Optional<Double> getHightestDelta(ObjectId graph_id) {
+        return Optional.of(mongoCollection().aggregate(List.of(new Document("$match", new Document("graph_id", graph_id)), new Document("$project", new Document("d", "$delta")), new Document("$sort", new Document("delta", -1))), EntityDouble.class).iterator().next()).map(d -> d.d);
     }
 }

api/src/main/java/pt/haslab/specassistant/repositories/ModelRepository.java

@@ -7,7 +7,7 @@
 import org.bson.Document;
 import org.bson.types.ObjectId;
 import pt.haslab.specassistant.data.models.Model;
-import pt.haslab.specassistant.data.transfer.EntityStringLong;
+import pt.haslab.specassistant.data.aggregation.EntityStringLong;
 
 import java.util.Collection;
 import java.util.Collections;

api/src/main/java/pt/haslab/specassistant/services/PolicyManager.java

@@ -42,6 +42,31 @@ private void clearPolicy(ObjectId graph_id) {
         edgeRepo.clearPolicyFromGraph(graph_id);
     }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
     public void policy_iteration(ObjectId graph_id, Double gamma, Reward r, Probability p) {
         boolean unstable = true;
         FutureUtil.inlineRuntime(randoomPolicy(graph_id));
@@ -93,7 +118,7 @@ public void policy_evaluation_mongo_pipeline(ObjectId graph_id, Double gamma, Re
         do {
             nodeRepo.unsetDelta(graph_id);
             nodeRepo.policyImprovemenentInnerLoop(graph_id, gamma, r, p);
-        } while (nodeRepo.getHightestDelta(graph_id).map(x -> x.delta > r.getRequiredPrecision()).orElse(false));
+        } while (nodeRepo.getHightestDelta(graph_id).map(delta -> delta > r.getRequiredPrecision()).orElse(false));
     }
 
     public CompletableFuture<Void> randoomPolicy(ObjectId graph_id) {
@@ -119,15 +144,15 @@ public Boolean policy_improvement(ObjectId graph_id, Double gamma, Reward r, Pro
                     if (!actions.isEmpty()) {
                         try {
 
-                        HintEdge old_ = actions.stream().filter(HintEdge::getPolicy).findFirst().orElseThrow();
-                        HintEdge new_ = actions.stream().max(Comparator.comparingDouble(x -> bellman(gamma, r, p, x, n, nodeRepo.findById(x.destination)))).orElseThrow();
+                            HintEdge old_ = actions.stream().filter(HintEdge::getPolicy).findFirst().orElseThrow();
+                            HintEdge new_ = actions.stream().max(Comparator.comparingDouble(x -> bellman(gamma, r, p, x, n, nodeRepo.findById(x.destination)))).orElseThrow();
 
-                        if (!Objects.equals(old_.id, new_.id)) {
-                            edgeRepo.removeFromPolicy(old_.id);
-                            edgeRepo.setAsPolicy(new_.id);
-                            improved.set(true);
-                        }
-                        }catch (NoSuchElementException e){
+                            if (!Objects.equals(old_.id, new_.id)) {
+                                edgeRepo.removeFromPolicy(old_.id);
+                                edgeRepo.setAsPolicy(new_.id);
+                                improved.set(true);
+                            }
+                        } catch (NoSuchElementException e) {
                             throw e;
                         }
                     }