Set the XDG_CACHE_HOME for tests #4572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure each test run is independent. Makes the tests * iface-error-test-1 * iface-th-test less flaky locally. Should not have any effect on the CI flakiness issue.
fendor
force-pushed
the
fix/tests-xdg-cache-home
branch
from
1a34302 to
7df2e36
Compare
soulomoon
reviewed
Apr 27, 2025
|
https://github.com/haskell/haskell-language-server/blob/master/.github/workflows/test.yml#L51 Outdated skip in CI. Gonna fix that! |
Ghcide test infrastructure was refactored to depend on `hls-test-utils`.
michaelpj
approved these changes
Apr 27, 2025
|
Test failures all look genuine, so more investigation is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure each test run is independent.
Makes the tests
less flaky locally. On my machine, these tests were consistently failing after the first successful execution (due to caching the
hiedbafaict.)Should not have any effect on the CI flakiness issue.