Skip to content

Loosen dependency bounds #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021
Merged

Loosen dependency bounds #1787

merged 4 commits into from
May 3, 2021

Conversation

berberman
Copy link
Collaborator

Since we've decided to stick to the PVP, we are able to relax the lower bounds of hls-plugin-api, ghcide, and hls-test-utils. We should also bp this PR to 1.1.0-hackage, the branch where we are going to upload hls-1.1.0 to Hackage, so that #1725 can be closed legitimately without doing Hackage revisions.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this works. I wish we had some way of testing these changes in CI

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label May 2, 2021
@berberman
Copy link
Collaborator Author

@Mergifyio backport 1.1.0-hackage

@mergify
Copy link
Contributor

mergify bot commented May 3, 2021

Command backport 1.1.0-hackage: pending

Waiting for the pull request to get merged

@mergify mergify bot merged commit 9308ff4 into master May 3, 2021
mergify bot pushed a commit that referenced this pull request May 3, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pepe Iborra <[email protected]>
(cherry picked from commit 9308ff4)

# Conflicts:
#	plugins/hls-refine-imports-plugin/hls-refine-imports-plugin.cabal
@mergify
Copy link
Contributor

mergify bot commented May 3, 2021

Command backport 1.1.0-hackage: success

Backports have been created

Ailrun pushed a commit that referenced this pull request May 3, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Pepe Iborra <[email protected]>
(cherry picked from commit 9308ff4)

# Conflicts:
#	plugins/hls-refine-imports-plugin/hls-refine-imports-plugin.cabal

Co-authored-by: Potato Hatsue <[email protected]>
@berberman berberman deleted the loosen-bounds branch May 5, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants