Skip to content

Inconsistent ghcide bounds in plugins #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
berberman opened this issue Apr 14, 2021 · 3 comments
Closed

Inconsistent ghcide bounds in plugins #1725

berberman opened this issue Apr 14, 2021 · 3 comments
Labels
CI Continuous integration old_type: meta Planing and organizing other issues

Comments

@berberman
Copy link
Collaborator

berberman commented Apr 14, 2021

In #1722, I bumped ghcide to 1.2.0.2, and changed ghcide bounds in plugins to ^>=1.2.0.2. But at that time I didn't realize that @pepeiborra had uploaded hls-retrie-plugin-1.0.0.2, hls-explicit-imports-plugin-1.0.0.2 , and hls-brittany-plugin-1.0.0.1 to hackage, whereas I made changes in cabal file without bumping their versions. That said we need revise these three plugins in hackage to make the bounds of ghcide in them consistent with https://github.com/haskell/haskell-language-server/tree/1.1.0.

@berberman berberman added CI Continuous integration old_type: meta Planing and organizing other issues labels Apr 14, 2021
@pepeiborra
Copy link
Collaborator

pepeiborra commented Apr 14, 2021

Hey @berberman I am sorry for the early upload, I thought that the release was done so I uploaded my plugins.

I have given you powers in Hackage to all my plugins in case you need to make a revision or upload a new version. But I confess I don't understand the problem. The plugins are compatible with ghcide >= 1.2 so I would think that the current bounds are fine according to the PVP.

I would say that the problem here is the ^>=1.2.0.2 bound in HEAD. What does that even mean? I know what >=1.2.0.2 means, but I am not sure about ^>=1.2.0.2. I think the bound should be >1.2.

@berberman
Copy link
Collaborator Author

ghcide ^>=1.2.0.2 is semantically identical to ghcide >=1.2.0.2 && <1.3, which says "we know that ghcide 1.2.0.2 is compatible." If we obey PVP, then we will know that it is compatible till the 1.3 version, indicating that the lower bound can be relexed to >=1.2, i.e. ghcide ^>=1.2.

Yeah, the bounds in Hackage now are the relexed ones, which in fact are more reasonable according to the PVP. My bad -- I shouldn't bump up the lower bounds. But for now, I think we'd better synchronize those in Hackage with in HEAD by revisions.

@pepeiborra
Copy link
Collaborator

Thanks for explaining ^>= to me! I always struggle with those and the Cabal docs are not very clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration old_type: meta Planing and organizing other issues
Projects
None yet
Development

No branches or pull requests

2 participants