Skip to content

Decouple the session loader into reader and writer over the cache #7361

Decouple the session loader into reader and writer over the cache

Decouple the session loader into reader and writer over the cache #7361

Triggered via pull request June 23, 2025 19:04
Status Success
Total duration 49s
Artifacts

hlint.yml

on: pull_request
Hlint check run
45s
Hlint check run
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
Hlint check run: ghcide/src/Development/IDE/Core/PluginUtils.hs#L219
Warning in activeDiagnosticsInRangeMT in module Development.IDE.Core.PluginUtils: Redundant lambda ▫︎ Found: "diagRangeOverlaps\n = \\ fileDiag\n -> rangesOverlap range (fileDiag ^. fdLspDiagnosticL . LSP.range)" ▫︎ Perhaps: "diagRangeOverlaps fileDiag\n = rangesOverlap range (fileDiag ^. fdLspDiagnosticL . LSP.range)"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L1106
Suggestion in getModSummaryFromImports in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "((ideclPkgQual i), reLoc $ ideclName i)" ▫︎ Perhaps: "(ideclPkgQual i, reLoc $ ideclName i)"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L826
Suggestion in generateHieAsts in module Development.IDE.Core.Compile: Redundant $ ▫︎ Found: "Just $ hie_asts" ▫︎ Perhaps: "Just hie_asts"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L73
Warning in module Development.IDE.Core.Compile: Use fewer imports ▫︎ Found: "import Development.IDE.Core.FileStore ( resetInterfaceStore )\nimport Development.IDE.Core.FileStore ( shareFilePath )\n" ▫︎ Perhaps: "import Development.IDE.Core.FileStore\n ( resetInterfaceStore, shareFilePath )\n"
Hlint check run: ghcide/session-loader/Development/IDE/Session/OrderedSet.hs#L1
Warning in module Development.IDE.Session.OrderedSet: Use module export list ▫︎ Found: "module Development.IDE.Session.OrderedSet where" ▫︎ Perhaps: "module Development.IDE.Session.OrderedSet (\n module Development.IDE.Session.OrderedSet\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L92
Warning in parseMultiCradleErr in module Development.IDE.Session.Diagnostics: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L1158
Suggestion in newComponentCache in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(homeUnitId_ (componentDynFlags ci)) `OS.member` bad_units" ▫︎ Perhaps: "homeUnitId_ (componentDynFlags ci) `OS.member` bad_units"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L960
Warning in loadCradleWithNotifications in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(isTesting)" ▫︎ Perhaps: "isTesting"
Hlint check run: exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/