-
Notifications
You must be signed in to change notification settings - Fork 60
Remove dependency on old network version #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Cabal-Version: 3.0 | ||
| Name: HTTP | ||
| Version: 4000.4.1 | ||
| x-revision: 5 | ||
| Build-type: Simple | ||
| License: BSD3 | ||
| License: BSD-3-Clause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to do this in the same PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsenag It would be really appreciated to move to the standard SPDX identifier for the license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, but does it need to be done in the same commit/PR? Particularly the Cabal version bump which could cause noise if later trying to track down some problem caused by the dependency changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsenag Cabal version change does not cause hard-to-debug problems because it conditions what version of the cabal library (through cabal-install or stack) can parse the file. Cabal 3.0 format support is around since 2019.
But I can separate the commit, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kleidukos @hsenag I do not think it is good to require cabal-version: 3.0 on the one hand (Cabal 3.0 was shipped with GHC 8.8) and base >= 4.6 (GHC 7.6) on the other hand.
Why not do the minimal bump on cabal-version and sync it with a base bump? E.g. cabal-version: 2.0 and base >= 4.10, setting GHC 8.2 as the last supported GHC version.
Ideally, cabal-version should be independent from the Cabal version, but it is not in practice.
This allows us to remove the flag. Fixes haskell#160
|
I'll look into shipping this soon if nobody else gets there first. |
|
Shipped in 4000.5.0 - thanks for the fixes |
This allows us to remove the flag.
Fixes #160