Skip to content

Conversation

@Kleidukos
Copy link
Member

This allows us to remove the flag.
Fixes #160

Comment on lines +1 to +6
Cabal-Version: 3.0
Name: HTTP
Version: 4000.4.1
x-revision: 5
Build-type: Simple
License: BSD3
License: BSD-3-Clause
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to do this in the same PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsenag It would be really appreciated to move to the standard SPDX identifier for the license.

Copy link
Member

@hsenag hsenag Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but does it need to be done in the same commit/PR? Particularly the Cabal version bump which could cause noise if later trying to track down some problem caused by the dependency changes.

Copy link
Member Author

@Kleidukos Kleidukos Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsenag Cabal version change does not cause hard-to-debug problems because it conditions what version of the cabal library (through cabal-install or stack) can parse the file. Cabal 3.0 format support is around since 2019.

But I can separate the commit, yes.

Copy link
Member

@andreasabel andreasabel Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kleidukos @hsenag I do not think it is good to require cabal-version: 3.0 on the one hand (Cabal 3.0 was shipped with GHC 8.8) and base >= 4.6 (GHC 7.6) on the other hand.
Why not do the minimal bump on cabal-version and sync it with a base bump? E.g. cabal-version: 2.0 and base >= 4.10, setting GHC 8.2 as the last supported GHC version.
Ideally, cabal-version should be independent from the Cabal version, but it is not in practice.

This allows us to remove the flag. Fixes haskell#160
@hsenag hsenag merged commit 0a2fca2 into haskell:master Nov 26, 2025
12 checks passed
@hsenag
Copy link
Member

hsenag commented Nov 26, 2025

I'll look into shipping this soon if nobody else gets there first.

@hsenag
Copy link
Member

hsenag commented Dec 10, 2025

Shipped in 4000.5.0 - thanks for the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The network-uri flag is incorrect

3 participants