Skip to content

fix unicode identifier parsing #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

obfusk
Copy link

@obfusk obfusk commented Oct 14, 2019

Correctly parse identifier that starts with a letter that is neither upper nor lower case (and should count as the latter); e.g. .

I'm guessing this needs to be fixed in more places; I'd be happy to look into that sometime later, but I'm not very familiar with the codebase and would appreciate some help. I just found this specific bug when fixing a bug in hoogle.

I also did not add any extra tests; I can also do that later if you'd like.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
correctly parse identifier that starts with a letter that is neither
upper nor lower case (and should count as the latter)
@obfusk
Copy link
Author

obfusk commented Oct 14, 2019

I suspect several other uses of isLower c should be isLetter c && not (isUpper c).

@DanBurton
Copy link
Contributor

Instead of merging this, I've added a commit to handle it more thoroughly: c9f786d

And a test: 94a3bcd

There's still something weird about prettyprinting these kinds of identifiers, though. See also: #443

@DanBurton DanBurton closed this Oct 15, 2019
@obfusk
Copy link
Author

obfusk commented Oct 15, 2019

Great! Thanks for saving me the extra work to handle it more thoroughly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants