Skip to content

Update tutorial language #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

joelmccracken
Copy link
Member

@joelmccracken joelmccracken commented Mar 3, 2025

This wording is hard to read in 2025, and effectively is no longer the standard terminology.

It appears to me that github should just publish this with the typical jekyll setup, and so it will be deployed if/when merged. I'm not certain tho.

This wording is hard to read in 2025, and effectively is no longer the
standard terminology.
@joelmccracken
Copy link
Member Author

oh fiddlesticks. I didn't realize there was an instance of slave in the actual api, not just the name chosen for the tutorial. not ready to merge yet.

@joelmccracken joelmccracken marked this pull request as draft March 3, 2025 23:33
@joelmccracken
Copy link
Member Author

Probably good enough for now, I'd like to investigate adding new API methods and deprecating the older ones

@joelmccracken joelmccracken marked this pull request as ready for review March 3, 2025 23:41
@LaurentRDC
Copy link
Member

Thanks! Let's see if this gets published on merge

@LaurentRDC LaurentRDC merged commit bd76864 into master Mar 4, 2025
@joelmccracken joelmccracken deleted the jnm/update-tutorial-language branch March 4, 2025 17:59
@joelmccracken
Copy link
Member Author

It published, just checked it on GH. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants