Skip to content

Network.Transport tutorial: Fixes for code mistakes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2017
Merged

Network.Transport tutorial: Fixes for code mistakes #18

merged 4 commits into from
Apr 5, 2017

Conversation

NCrashed
Copy link
Contributor

The tutorial won't operate properly due:

  • Windows platform still needs withSocketsDo with current haskell-platform
  • Although code is up to date in separate .hs files, there are some places with old fromFunction and absence of defaultTCPParameters

The PR fixes this problems with minimal diff.

Anton Gushcha added 3 commits July 19, 2015 13:42
Update tutorial-client.hs
158a6fd 
withSocketsDo for Windows platform
Update tutorial-server.hs
9aeb3da 
withSocketsDo for Windows platform
Update tutorial-NT2.md
eb6d75d 
Add withSocketsDo for Windows platform, fromString is now pack
@mboes
Copy link
Contributor

mboes commented Jul 19, 2015

Thanks for spotting this. In general we have a darth of testing resources on Windows, so if you're willing to help us out on that platform, that would be great!

withSocketsDo isn't needed even on Windows for recent versions of network. Since many Windows users seem to prefer MinGHC to using the platform, could you perhaps explain that withSockets do may be required for older versions but is otherwise not something to worry about?

Update tutorial-NT2.md
e516238 
withSocketsDo may be needed, emphasize the point
@NCrashed
Copy link
Contributor Author

Thanks for spotting this. In general we have a darth of testing resources on Windows, so if you're willing to help us out on that platform, that would be great!

I will help as I can, but the Windows platform isn't usual environment for me.

I was testing Windows related bugs for my project and found haskell-distributed/network-transport-tcp#35 and haskell-distributed/distributed-process#435, after that I was trying to minify bug example and the roughnesses with tutorial revealed.

gelisam added a commit to gelisam/chopt-test-task that referenced this pull request Oct 16, 2016
@gelisam
Revert "add withProcessDo"
5ffaedf 
This reverts commit 90cd48d.

I have read [1] that withSocketsDo is no longer required.

[1] haskell-distributed/haskell-distributed.github.com#18 (comment)
@hyperthunk hyperthunk requested review from mboes and qnikst February 9, 2017 11:21
@hyperthunk
Copy link
Member

@mboes are we good to merge this?

@mboes mboes merged commit ab2f241 into haskell-distributed:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes Awaiting requested review from mboes

@qnikst qnikst Awaiting requested review from qnikst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NCrashed @mboes @hyperthunk