Don't carry all -replace addresses through to every instance
#37833
+22
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Once we have a resource instance we no longer need to have all possible forceReplace addresses available within that instance. We can determine immediately if the instance address is in the set if replacement addresses. This avoids bugs caused by sharing the `-replace` flag addresses across all resource nodes.
jbardin
force-pushed
the
jbardin/force-replace-instance
branch
from
b3140f9 to
cac484d
Compare
jbardin
changed the title
-replace addresses through to every instance
jbardin
added
the
1.14-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we have a resource instance we no longer need to have all possible
forceReplaceaddresses, we can determine immediately if the instance address is in the set of replacement addresses. This avoids bugs caused by sharing the-replaceflag addresses across all resource nodes.After working out a regression test for this, it became apparent that the test was not useful at all. It's not possible to regress this fix if the shared slice no longer exists, and even then relies on Go implementation details to get the slice len and cap to line up for the sharing to happen, so it may never fail again in the future. Since no behavior changes have been made, the existing test coverage should be sufficient.
Fixes #37831