Skip to content

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 5, 2025

See hashicorp/go-getter#548 and hashicorp/go-getter#549

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@YakDriver YakDriver requested review from a team as code owners September 5, 2025 21:41
@YakDriver YakDriver added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Sep 5, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a persistent failure in this S3 backend acceptance test with this change.

% TF_ACC=1 go test -count=1 ./... -run=TestRemoteClient_stateChecksum
--- FAIL: TestRemoteClient_stateChecksum (11.53s)
    client_test.go:314: TestBackendConfig on *s3.Backend with configtesting.synthBody{Filename:"<TestWrapConfig>", Values:map[string]cty.Value{"bucket":cty.StringVal("terraform-remote-s3-test-68bedf58"), "dynamodb_table":cty.StringVal("terraform-remote-s3-test-68bedf58"), "key":cty.StringVal("testState")}}
    client_test.go:320: creating S3 bucket terraform-remote-s3-test-68bedf58 in us-east-1
    backend_test.go:3649: creating DynamoDB table terraform-remote-s3-test-68bedf58
    client_test.go:346: TestBackendConfig on *s3.Backend with configtesting.synthBody{Filename:"<TestWrapConfig>", Values:map[string]cty.Value{"bucket":cty.StringVal("terraform-remote-s3-test-68bedf58"), "key":cty.StringVal("testState")}}
    client_test.go:389: expected state checksum error: got state data in S3 does not have the expected content.

        The checksum calculated for the state stored in S3 does not match the checksum
        stored in DynamoDB.

        Bucket: terraform-remote-s3-test-68bedf58
        Key:    testState
        Calculated checksum:
        Stored checksum:     bf36014ebaea5474d1278bbafb66a2c5

        This may be caused by unusually long delays in S3 processing a previous state
        update. Please wait for a minute or two and try again.

        If this problem persists, and neither S3 nor DynamoDB are experiencing an
        outage, you may need to manually verify the remote state and remove the Digest
        value stored in the DynamoDB table
FAIL
FAIL    github.com/hashicorp/terraform/internal/backend/remote-state/s3 11.992s
FAIL

@jar-b
Copy link
Member

jar-b commented Sep 8, 2025

Correction - this is also failing on main (attributing to this change was bad assumption on my part since I haven't run acceptance tests in a few weeks). Will see if I can identify potential related changes.

@jar-b
Copy link
Member

jar-b commented Sep 8, 2025

Impacted test has been fixed via #37571. All other S3 backend tests were passing on this branch as-is.

@YakDriver YakDriver merged commit 74b0925 into main Sep 8, 2025
12 of 13 checks passed
@YakDriver YakDriver deleted the dep-bump-go-getter branch September 8, 2025 16:25
@YakDriver
Copy link
Member Author

Sweet! Thanks @jar-b @SarahFrench @jbardin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants