Update get provider schema to include state store information #36834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
SarahFrench
changed the base branch from
main
to
radek/pluggable-backends-protocol
SarahFrench
commented
Apr 2, 2025
internal/grpcwrap/provider.go
Outdated
| @@ -73,6 +74,7 @@ func (p *provider) GetSchema(_ context.Context, req *tfplugin5.GetProviderSchema | |||
| Block: convert.ConfigSchemaToProto(dat.Body), | |||
| } | |||
| } | |||
| // Do we add state stores here? Why aren't ephemeral resources here? | |||
There was a problem hiding this comment.
This confused me, and I'll take another look tomorrow
There was a problem hiding this comment.
Added in 81b44cf
I think ephemeral resources were omitted here accidentally, and that didn't matter because it's a testing resource for E2E tests.
SarahFrench
commented
Apr 2, 2025
radeksimko
reviewed
Apr 3, 2025
radeksimko
reviewed
Apr 3, 2025
radeksimko
reviewed
Apr 3, 2025
|
I think this is at an ok level of completion for merging into the prototyping branch (assuming no glaring errors). Having this implemented unblocks any code that may use the provider schema response data. |
radeksimko
approved these changes
Apr 7, 2025
2 tasks
radeksimko
force-pushed
the
radek/pluggable-backends-protocol
branch
from
6ff3410 to
b54b90e
Compare
Co-authored-by: Radek Simko <[email protected]>
radeksimko
force-pushed
the
sarah/update-get-provider-schema
branch
from
5742c22 to
122ca70
Compare
radeksimko
merged commit fd74a25
into
radek/pluggable-backends-protocol
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GetProviderSchema/GetSchema response so that it includes info about state stores.