Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom default for namespace #1520

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

JaylonmcShan03
Copy link
Contributor

Description

This PR introduces a custom default value for the namespace attribute in the HelmRelease resource. The default is set to use the HELM_NAMESPACE environment variable, or fall back to "default" if the variable is not defined.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner October 28, 2024 13:31
@JaylonmcShan03 JaylonmcShan03 merged commit 679b92b into helm-framework Nov 8, 2024
5 of 10 checks passed
@JaylonmcShan03 JaylonmcShan03 deleted the namespace-default-adjustment branch November 8, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants