Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix resourcediff error #1353

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Hotfix resourcediff error #1353

merged 2 commits into from
Apr 15, 2024

Conversation

jrhouston
Copy link
Contributor

Description

This PR reverts a change made which caused errors to be returned at plan time when they should not be.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner April 15, 2024 15:06
@BBBmau
Copy link
Contributor

BBBmau commented Apr 15, 2024

For context this issue was found here: d533734#r140651649

@jrhouston jrhouston merged commit 8d8f050 into main Apr 15, 2024
16 of 17 checks passed
@jrhouston jrhouston deleted the hotfix-resourcediff-error branch April 15, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees
No one assigned
Labels
pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrhouston @BBBmau