Skip to content

Add examples for two Waypoint resources #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

paladin-devops
Copy link
Contributor

This PR adds a couple of Waypoint resource examples.

@paladin-devops paladin-devops requested a review from a team December 18, 2024 22:10
@paladin-devops paladin-devops self-assigned this Dec 18, 2024
@paladin-devops paladin-devops force-pushed the waypoint-resource-examples branch from 36180d3 to ff51223 Compare December 18, 2024 22:11
@paladin-devops paladin-devops changed the title docs: Add examples for two Waypoint resources. Add examples for two Waypoint resources Dec 18, 2024
@paladin-devops paladin-devops marked this pull request as ready for review December 18, 2024 22:12
@paladin-devops paladin-devops requested review from a team as code owners December 18, 2024 22:12
Base automatically changed from WAYP-3107 to main December 19, 2024 15:51
@pierluc-codes
Copy link
Contributor

@paladin-devops is it still important?

@paladin-devops
Copy link
Contributor Author

@pierluc-codes yes, I need to merge the examples in this PR with those that were added in a recent PR, still. I'll convert this back to draft until that is ready.

@paladin-devops paladin-devops marked this pull request as draft February 4, 2025 15:50
@paladin-devops paladin-devops force-pushed the waypoint-resource-examples branch from ff51223 to 3cc4eef Compare February 5, 2025 16:24
@paladin-devops paladin-devops added documentation Improvements or additions to documentation pr/no-changelog Auto-pinning labels Feb 5, 2025
@paladin-devops paladin-devops marked this pull request as ready for review February 5, 2025 16:25
@pierluc-codes
Copy link
Contributor

@paladin-devops can you get a review from you team please?

@paladin-devops
Copy link
Contributor Author

@pierluc-codes I have pinged my team about it.

Copy link
Member

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@paladin-devops paladin-devops merged commit 6747091 into main Feb 5, 2025
8 of 9 checks passed
@paladin-devops paladin-devops deleted the waypoint-resource-examples branch February 5, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pr/no-changelog Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants