-
Notifications
You must be signed in to change notification settings - Fork 67
Add network association resources #206
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @simonbrady - Thanks for submitting this PR, it seems strange that ability to provision "azurestack_subnet" is missing from the v1.0.0 release. The associated you mentioned PR here, was successfully merged. @tombuildsstuff - Are you able to review / approve this PR, as it would greatly improve v1.0.0, or perhaps it would justify a v1.1.0 release once tested? As without it there is no ability to provision using network_security_group_id and route_table_id for associations of SDN resources. @katbyte - Would you have time be review / approve this PR? In addition to the above ask for @tombuildsstuff |
…et_id and network_security_group_id
…nt resource function naming
…o match resource name
|
Thanks for the comments @NeilBird - for tidiness's sake I've rebased this PR to ensure it still merges cleanly. |
|
Hi all, I'm new to using Terraform with Azurestack. Cheers, |
Ports the following resources from the current
azurermprovider, making the minimum changes necessary to avoid any cascading dependency changes:azurestack_network_interface_security_group_associationazurestack_subnet_network_security_group_associationazurestack_subnet_route_table_associationThis addresses #204 and updates the
azurestack_subnetdocumentaton to address #195.All acceptance tests pass on Azure Stack Hub 2206, and all documentation examples for the new resources deploy on this version.
Note that I've renamed the source files for
azurestack_network_interface_security_group_associationto match the resource name, and submitted this PR to make the corresponding change for theazurermprovider.