Skip to content

Conversation

@brendanelmes
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

None

Description

Introduces new resource aws_applicationsignals_service_level_objective for managing Service Level Objectives.

Relations

Relates #39555

References

Output from Acceptance Testing

make testacc TESTS='TestAccApplicationSignalsServiceLevelObjective' PKG=applicationsignals 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-service-level-objective_resource 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/applicationsignals/... -v -count 1 -parallel 20 -run='TestAccApplicationSignalsServiceLevelObjective'  -timeout 360m -vet=off
2025/11/21 11:54:30 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/21 11:54:30 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccApplicationSignalsServiceLevelObjective_basic
=== PAUSE TestAccApplicationSignalsServiceLevelObjective_basic
=== RUN   TestAccApplicationSignalsServiceLevelObjective_disappears
=== PAUSE TestAccApplicationSignalsServiceLevelObjective_disappears
=== RUN   TestAccApplicationSignalsServiceLevelObjective_update
=== PAUSE TestAccApplicationSignalsServiceLevelObjective_update
=== RUN   TestAccApplicationSignalsServiceLevelObjective_full
=== PAUSE TestAccApplicationSignalsServiceLevelObjective_full
=== CONT  TestAccApplicationSignalsServiceLevelObjective_basic
=== CONT  TestAccApplicationSignalsServiceLevelObjective_update
=== CONT  TestAccApplicationSignalsServiceLevelObjective_full
=== CONT  TestAccApplicationSignalsServiceLevelObjective_disappears
--- PASS: TestAccApplicationSignalsServiceLevelObjective_disappears (14.10s)
--- PASS: TestAccApplicationSignalsServiceLevelObjective_full (16.41s)
--- PASS: TestAccApplicationSignalsServiceLevelObjective_basic (16.44s)
--- PASS: TestAccApplicationSignalsServiceLevelObjective_update (24.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/applicationsignals 30.523s

@brendanelmes brendanelmes requested a review from a team as a code owner November 21, 2025 12:42
@github-actions
Copy link
Contributor

Welcome @brendanelmes 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider repository. Thank you very much for taking the time to do so, and welcome to the community! 🎉


Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. generators Relates to code generators. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. size/XL Managed by automation to categorize the size of a PR. labels Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants