Skip to content

Conversation

pablo19sc
Copy link
Contributor

@pablo19sc pablo19sc commented Aug 29, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes in security controls, only documentation update and removal of deprecated attributes.

Description

  • Updated documentation to reflect the need to use the resource aws_dx_connection_confirmation to accept the Hosted Connection in another AWS Account.
  • No changes in resource functionality

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDirectConnectHostedConnection_basic PKG=directconnect

TF_ACC=1 go1.24.6 test ./internal/service/directconnect/... -v -count 1 -parallel 20 -run='TestAccDirectConnectHostedConnection_basic'  -timeout 360m -vet=off
2025/08/29 12:06:00 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/29 12:06:00 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDirectConnectHostedConnection_basic
=== PAUSE TestAccDirectConnectHostedConnection_basic
=== CONT  TestAccDirectConnectHostedConnection_basic
--- PASS: TestAccDirectConnectHostedConnection_basic (14.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      19.745s
...

@pablo19sc pablo19sc requested a review from a team as a code owner August 29, 2025 10:06
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Contributor

github-actions bot commented Aug 29, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/directconnect Issues and PRs that pertain to the directconnect service. size/S Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Aug 29, 2025
@ewbankkit
Copy link
Contributor

@pablo19sc Thanks for the contribution.
Removal of deprecated attributes can only occur at a major version as it is a breaking change.
Could you please split into 2 PRs, one with the documentation updates (minus the attribute removals) and the deprecation of lag_id and then another (which will target v7.0.0) with the removals?

@ewbankkit ewbankkit added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 29, 2025
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Aug 30, 2025
@pablo19sc
Copy link
Contributor Author

Hi @ewbankkit, thanks for the clarification. I kept this PR as the documentation update. Then, #44096 does the deprecation of attributes.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/directconnect Issues and PRs that pertain to the directconnect service. size/S Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants