Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add manual_creation argument to aws_codebuild_webhook resource #40155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

phuhung273
Copy link

@phuhung273 phuhung273 commented Nov 17, 2024

Description

  • Add manual_creation argument to aws_codebuild_webhook resource

Relations

Closes #40078

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCodeBuildWebhook_manualCreation PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildWebhook_manualCreation'  -timeout 360m
2024/11/17 14:21:30 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeBuildWebhook_manualCreation
=== PAUSE TestAccCodeBuildWebhook_manualCreation
=== CONT  TestAccCodeBuildWebhook_manualCreation
--- PASS: TestAccCodeBuildWebhook_manualCreation (45.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  46.059s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. needs-triage Waiting for first response or review from a maintainer. labels Nov 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @phuhung273 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@phuhung273 phuhung273 marked this pull request as ready for review November 17, 2024 07:53
@phuhung273 phuhung273 requested a review from a team as a code owner November 17, 2024 07:53
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 17, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
@kieran-lowe
Copy link
Contributor

Any updates on getting this merged in?

@phuhung273
Copy link
Author

Any updates on getting this merged in?

Im still waiting for maintainer review. Let's be patient, just a very beginning of the year.

@avidspartan1
Copy link

Any updates here?

@avidspartan1
Copy link

Hey, @jar-b - apologies in advance for direct pinging you. How can we move this PR forward? Do we just need to continue waiting and someone will get to it eventually?

@jar-b
Copy link
Member

jar-b commented Apr 1, 2025

Hey @avidspartan1 - our current focus is on items for the V6 major release. Once that is GA we'll return to reviewing enhancements based on the prioritization guide linked in the comments above.

@avidspartan1
Copy link

Thanks, Jared. I thought I'd read all of the contributing guidelines, but I missed the prioritization FAQ. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add manualCreation argument to aws_codebuild_webhook resource
5 participants