Skip to content

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Apr 22, 2025

This PR adds support for ImportStatePassthroughWithIdentity which makes it easier to implement support for import by identity if the fallback Id attribute is part of the identity object (e.g. if it's a UUID or ARN that can just be copied as is from an attribute of the identity object into the Id string).

@ansgarm ansgarm requested a review from a team as a code owner April 22, 2025 14:50
@ansgarm ansgarm changed the title add ImportStatePassthroughWithIdentity TFECO-9286 add ImportStatePassthroughWithIdentity Apr 22, 2025
@ansgarm ansgarm changed the title TFECO-9286 add ImportStatePassthroughWithIdentity TFECO-9286: add ImportStatePassthroughWithIdentity Apr 22, 2025
@austinvalle austinvalle added this to the v2.37.0 milestone Apr 22, 2025
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have a suggestion for documentation and one additional test case

@ansgarm ansgarm requested a review from austinvalle April 23, 2025 08:57
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ansgarm ansgarm merged commit 34b8271 into main Apr 23, 2025
22 checks passed
@ansgarm ansgarm deleted the import-state-passthrough-with-identity branch April 23, 2025 12:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants