list: set empty objects in NewListResult
#1207
Merged
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
commented
Aug 19, 2025
internal/fwschemadata/data_set.go
Outdated
Comment on lines
19
to
22
| if v, ok := val.(tftypes.Value); ok { | ||
| d.TerraformValue = v | ||
| return nil | ||
| } |
There was a problem hiding this comment.
We probably want to check that the supplied val actually corresponds to the schema of the object we're setting this too?
There was a problem hiding this comment.
This has been moved over into #1198 since it's related to that piece of work
stephybun
force-pushed
the
f/new-listresult-empty-object
branch
2 times, most recently
from
074bdbb to
d8b708d
Compare
austinvalle
approved these changes
Aug 20, 2025
stephybun
force-pushed
the
f/new-listresult-empty-object
branch
from
d8b708d to
588762b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ResourceIdentityandResourcein theNewListResultmethodRollback Plan
Changes to Security Controls
None