Add policy to allow Vault user to rotate its own creds; other small improvements #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nphilbrook
changed the title
nphilbrook
changed the title
nphilbrook
changed the title
| @@ -10,6 +10,7 @@ provider "vault" { | |||
| # | |||
| # https://registry.terraform.io/providers/hashicorp/vault/latest/docs/resources/jwt_auth_backend | |||
| resource "vault_jwt_auth_backend" "tfc_jwt" { | |||
| namespace = var.vault_namespace | |||
There was a problem hiding this comment.
I like this a lot more than pulling the namespace from the provider 👍 Thanks!
SwiftEngineer
approved these changes
May 29, 2025
|
Thank you @SwiftEngineer , I lack merge perms on this repo so if you wouldn't mind doing the squash merge I would appreciate it! |
|
You got it @nphilbrook 👍 Thanks for the PR!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this locally, can see the results here - https://gist.github.com/nphilbrook/92bfbf04c41f35026d8261f15700e9d5
Also actually used the HCP TF workspace to use the perms and it also worked 🎉