chore(deps): bump github.com/hashicorp/packer-plugin-sdk from 0.6.0 to 0.6.1 #520
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
tenthirtyam
changed the title
tenthirtyam
force-pushed
the
dependabot/go_modules/github.com/hashicorp/packer-plugin-sdk-0.6.1
branch
3 times, most recently
from
1a04572 to
f3bc723
Compare
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/hashicorp/packer-plugin-sdk-0.6.1
branch
from
f3bc723 to
24c8825
Compare
Bumps [github.com/hashicorp/packer-plugin-sdk](https://github.com/hashicorp/packer-plugin-sdk) from 0.6.0 to 0.6.1. - [Release notes](https://github.com/hashicorp/packer-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/packer-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/packer-plugin-sdk@v0.6.0...v0.6.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/packer-plugin-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
lbajolet-hashicorp
force-pushed
the
dependabot/go_modules/github.com/hashicorp/packer-plugin-sdk-0.6.1
branch
from
24c8825 to
56f93d4
Compare
|
Huh, the generation changes are worrying a bit, I think we'll need to investigate why those changes happened before merging this, it could be a bug with |
Yeah, it's really acting whacky. Generation fails with the toolchain directive, but then if you generate you will see changes to the |
Version 1.54.2 of the golangci-lint tool is not compatible with go 1.23, which is the version the project is now compiled with. In order for CI to be able to run correctly, we are therefore bumping the golangci-lint dependency to 1.60.1 now, so that the lint job can run again.
A series of changes have made the current .golangci.yml configuration file non-conformant with latest updates, causing warnings and errors when attempting to run the tool on the plugin. This commit fixes all the reported issues with the configurtion, removing dead checkers and updating the deprecated/removed options in the config file.
With the 1.60.1 update to golangci-lint and the configuration changes, some more linting errors were reported by the linter now, so we fix those that appeared.
|
Thanks for the approval @tenthirtyam, just to be clear, I think this PR should not be immediately merged because still of the changes in the generated code. I'm worried this could be a side-effect of a change in the Go libs which causes some unexpected changes in this case, so we should understand why those changes suddenly appear, and assess if they're legit or due to a bug in packer-sdc |
Bumps github.com/hashicorp/packer-plugin-sdk from 0.6.0 to 0.6.1.
Release notes
Sourced from github.com/hashicorp/packer-plugin-sdk's releases.
Commits
d037325version: cut release v0.6.19800105go.mod: bump go-jose to 4.0.599a6159go.mod: remove toolchain statement9417a76deps: update golang depends and bump go version to >=1.23ae49fa1ci: remove go 1.21 and go 1.22 from test matrixebb7876ci: run tests against go 1.23 and 1.24bbf8adcversion: prepare v0.6.1-dev6f42498version: cut release v0.6.06207578go.mod: tidy up go.mod/go.sumDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)