Skip to content

Allow output box path to be customized #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nayanshah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow output box path to be customized #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions builder/vagrant/driver_2_2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import (
"log"
"os"
"os/exec"
"path/filepath"
"regexp"
"slices"
"strings"

"github.com/hashicorp/go-version"
Expand Down Expand Up @@ -74,17 +76,11 @@ func (d *Vagrant_2_2_Driver) Destroy(id string) error {

// Calls "vagrant package"
func (d *Vagrant_2_2_Driver) Package(args []string) error {
// Ideally we'd pass vagrantCWD into the package command but
// we have to change directory into the vagrant cwd instead in order to
// work around an upstream bug with the vagrant-libvirt plugin.
// We can stop doing this when
// https://github.com/vagrant-libvirt/vagrant-libvirt/issues/765
// is fixed.
oldDir, _ := os.Getwd()
_ = os.Chdir(d.VagrantCWD)
//nolint
defer os.Chdir(oldDir)
args = append(args, "--output", "package.box")
// Use default output path if not already provided
if !slices.Contains(args, "--output") {
outputPath = filepath.Join(d.VagrantCWD, "package.box")
args = append(args, "--output", outputPath)
}
_, _, err := d.vagrantCmd(append([]string{"package"}, args...)...)
return err
}
Expand Down