Skip to content

Conversation

@aklkv
Copy link
Contributor

@aklkv aklkv commented Sep 24, 2025

Description

resolve: #26801

While migrating to pnpm which has much stricter dependancies resolution rules we missed a couple of deps that needs to be explicitly installed such as one that broke flyout component @ember/test-helpers

Testing & Reproduction steps

Links

NMD-1004

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@jrasell
Copy link
Member

jrasell commented Oct 3, 2025

Hi @aklkv and thanks for raising this. Are you able to take a look into the failing tests please?

@aklkv
Copy link
Contributor Author

aklkv commented Oct 3, 2025

@jrasell I have, and consulted with @philrenaud and it seems to be known flaky test

@philrenaud
Copy link
Contributor

Confirming that it's flakey but eventually passes on rerun, yes?

@aklkv
Copy link
Contributor Author

aklkv commented Oct 6, 2025

for the life of me I can't reproduce it locally to try to fix it as it's just passes locally 😔

@philrenaud
Copy link
Contributor

It's a timed test by its very nature ("make sure a user gets a notification that their token is soon to time-out!") which makes it implicitly a little flakey, but I've been shocked at how flakey it's become over time. It has gone from a 99% pass rate to something like 10% over the past year or so.

It would not be unreasonable to rewrite the test to be more isolated, or even to abstract away the timer and pass in a boolean to the test component indicating it should show a warning or something.

@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Oct 8, 2025
@jrasell
Copy link
Member

jrasell commented Oct 14, 2025

I've skipped the test on main and raised a followup backlog ticket for it. @aklkv do you mind merging main into this branch which should clear up the test failure and add a changelog entry, as this fixes a user facing bug. We have the make cl command available for this.

@jrasell jrasell added the backport/1.10.x backport to 1.10.x release line label Oct 16, 2025
@jrasell jrasell self-assigned this Oct 16, 2025
@jrasell jrasell added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent labels Oct 16, 2025
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aklkv!

I've tested this out locally too and can see it fixed the linked issue.

@aklkv aklkv merged commit 5eb7553 into main Oct 17, 2025
56 of 58 checks passed
@aklkv aklkv deleted the fix/missing-deps branch October 17, 2025 11:34
@github-project-automation github-project-automation bot moved this from In Progress to Done in Nomad - Community Issues Triage Oct 17, 2025
jrasell pushed a commit that referenced this pull request Oct 17, 2025
jrasell pushed a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.10.x backport to 1.10.x release line

Projects

Development

Successfully merging this pull request may close these issues.

Nomad UI action fly-out doesn't show properly

3 participants