- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2k
fix(ui): add missing deps #26833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): add missing deps #26833
Conversation
| Hi @aklkv and thanks for raising this. Are you able to take a look into the failing tests please? | 
| @jrasell I have, and consulted with @philrenaud and it seems to be known flaky test | 
| Confirming that it's flakey but eventually passes on rerun, yes? | 
fe06cff    to
    e437e3a      
    Compare
  
    | for the life of me I can't reproduce it locally to try to fix it as it's just passes locally 😔 | 
| It's a timed test by its very nature ("make sure a user gets a notification that their token is soon to time-out!") which makes it implicitly a little flakey, but I've been shocked at how flakey it's become over time. It has gone from a 99% pass rate to something like 10% over the past year or so. It would not be unreasonable to rewrite the test to be more isolated, or even to abstract away the timer and pass in a boolean to the test component indicating it should show a warning or something. | 
| I've skipped the test on main and raised a followup backlog ticket for it. @aklkv do you mind merging main into this branch which should clear up the test failure and add a changelog entry, as this fixes a user facing bug. We have the  | 
e437e3a    to
    51be6be      
    Compare
  
    51be6be    to
    6891e8b      
    Compare
  
    resolve: #26801 refs: [NMD-1004](https://hashicorp.atlassian.net/browse/NMD-1004)
6891e8b    to
    a12e67c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @aklkv!
I've tested this out locally too and can see it fixed the linked issue.
Co-authored-by: Alexey Kulakov <[email protected]>
Description
resolve: #26801
While migrating to
pnpmwhich has much stricter dependancies resolution rules we missed a couple of deps that needs to be explicitly installed such as one that broke flyout component@ember/test-helpersTesting & Reproduction steps
Links
NMD-1004
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.