Skip to content

Fix comparison bug when comparing non-numeric prereleases #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix comparison bug when comparing non-numeric prereleases #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,17 +212,11 @@ func comparePart(preSelf string, preOther string) int {

// if a part is empty, we use the other to decide
if preSelf == "" {
if otherNumeric {
return -1
}
return 1
return -1
}

if preOther == "" {
if selfNumeric {
return 1
}
return -1
return 1
}

if selfNumeric && !otherNumeric {
Expand Down
4 changes: 3 additions & 1 deletion version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ func TestComparePreReleases(t *testing.T) {
{"3.0-alpha.3", "3.0-rc.1", -1},
{"3.0-alpha3", "3.0-rc1", -1},
{"3.0-alpha.1", "3.0-alpha.beta", -1},
{"5.4-alpha", "5.4-alpha.beta", 1},
{"5.4-alpha", "5.4-alpha.beta", -1},
{"5.4-beta", "5.4-alpha.beta", 1},
{"5.4-beta.2", "5.4-alpha.beta", 1},
{"v1.2-beta.2", "v1.2-beta.2", 0},
{"v1.2-beta.1", "v1.2-beta.2", -1},
{"v3.2-alpha.1", "v3.2-alpha", 1},
Expand Down