Skip to content

Add AgentPool to OAuthClientUpdateOptions #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpogran
Copy link

@jpogran jpogran commented Mar 6, 2025

Description

This change adds an AgentPool field to the OAuthClientUpdateOptions struct, which is used to associate a VCS Provider with an AgentPool for PrivateVCS support.

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Mar 10, 2025

Datadog Report

Branch report: add_agent_pool_update
Commit report: 8945e94
Test service: hashicorp/go-tfe

✅ 0 Failed, 1440 Passed, 168 Skipped, 13m 47.99s Total Time
➡️ Test Sessions change in coverage: 1 no change

@jpogran jpogran marked this pull request as ready for review March 10, 2025 17:00
@jpogran jpogran requested a review from a team as a code owner March 10, 2025 17:00
@jpogran jpogran force-pushed the add_agent_pool_update branch from 062e800 to 4e5504d Compare April 2, 2025 18:17
@jpogran jpogran requested a review from ctrombley April 3, 2025 11:51
CHANGELOG.md Outdated
Comment on lines 11 to 13
* Add AgentPool to OAuthClientUpdateOptions

Add `AgentPool` field to the OAuthClientUpdateOptions struct, which is used to associate a VCS Provider with an AgentPool for PrivateVCS support by @jpogran [#1075](https://github.com/hashicorp/go-tfe/pull/1075)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an additive change, should this be categorized under the Enhancements heading?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Moved to enhancements

@roleesinhaHC roleesinhaHC requested a review from ctrombley April 17, 2025 17:29
This change adds an AgentPool field to the OAuthClientUpdateOptions struct, which is used to associate a VCS Provider with an AgentPool for PrivateVCS support.
@jpogran jpogran force-pushed the add_agent_pool_update branch from b4c3375 to 9c61348 Compare April 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants