chore: 🤖 create patched ember-loading to use modern ember-concurrency #3015
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashicc
changed the title
hashicc
force-pushed
the
patch-ember-loading
branch
2 times, most recently
from
00befb0 to
9a8b485
Compare
hashicc
force-pushed
the
patch-ember-loading
branch
from
9a8b485 to
f9e26ae
Compare
| @@ -0,0 +1,112 @@ | |||
| diff --git a/addon/services/loading.ts b/addon/services/loading.ts | |||
There was a problem hiding this comment.
| module.exports = { | ||
| name: require('./package').name, | ||
| + options: { | ||
| + babel: { | ||
| + plugins: [ | ||
| + require.resolve('ember-concurrency/async-arrow-task-transform'), | ||
| + ], | ||
| + }, | ||
| + }, | ||
| }; |
There was a problem hiding this comment.
hashicc
force-pushed
the
patch-ember-loading
branch
from
f9e26ae to
1a74a79
Compare
| "ember-try-config>package-json": "^10.0.1", | ||
| "ember-stargate@^0.6.0>@glimmer/component": "^2.0.0" | ||
| "ember-stargate@^0.6.0>@glimmer/component": "^2.0.0", | ||
| "ember-loading>ember-concurrency": "^4.0.0" |
There was a problem hiding this comment.
Is this needed? It looks like you changed the ember-loading package.json to instead make ember-concurrency a peer dep, would it not just load our app's version now?
There was a problem hiding this comment.
Patching the dependency's package.json doesn't actually change what gets installed so the manual overrides to ember-concurrency v4 is also needed.
I treated the patch as what the package output should be, but unfortunately the way the patches are resolved don't impact how the dependencies are managed and stored in the lockfile. Aside from changing the version I wanted to hint at that ember-concurrency-async and ember-concurrency-ts shouldn't be used, but those are also in the lockfile still. If this is more confusing than helpful I can remove the dependency changes from the package.json patch
hashicc
force-pushed
the
patch-ember-loading
branch
from
1a74a79 to
06a62e0
Compare
Description
This adds a patch for
ember-loadingdependency since it uses older ember-concurrency versions and supporting addons which prevent us from using vite-compatible addons. Patching the dependency'spackage.jsondoesn't actually change what gets installed so the manual overrides toember-concurrencyv4 is also needed.How to Test
is-loading: {{is-loading}}to theapplication.hbsin desktop or adminserver.timing = 1000to the mirage scenario or use the app with a real apiis-loading: truein the browser and then when the loading is finished theis-loading: falseshould be shownChecklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.