Skip to content

Migrate away from component helper in credential library form component #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

Migrate away from component helper in credential library form component #3013

merged 2 commits into from
Oct 7, 2025

Conversation

hashicc
Copy link
Collaborator

@hashicc hashicc commented Sep 29, 2025 •
edited
Loading

Description

This pr continues the migration away from the dynamic {{component}} helper. More information in #2880. This pull request focuses on migrating the credential-library form component.

🎟️ Jira ticket

How to Test

  • Tests should pass
  • Navigate to /scopes/:project_id/credential-stores/:credential_store_id/credential-libraries and create or edit credential libraries. The forms for all credential types should load correctly

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel Vercel
Copy link

vercel bot commented Sep 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Oct 7, 2025 2:20pm
boundary-ui-desktop Ready Ready Preview Comment Oct 7, 2025 2:20pm

@hashicc hashicc force-pushed the migrate-component-helper-app-components-form-credential-library-index branch from c016245 to 060133a Compare September 29, 2025 20:00
@hashicc hashicc marked this pull request as ready for review October 1, 2025 14:20
@hashicc hashicc requested a review from a team as a code owner October 1, 2025 14:20
@hashicc hashicc force-pushed the migrate-component-helper-app-components-form-credential-library-index branch from 47e95c3 to 77a3220 Compare October 1, 2025 14:20
@hashicc hashicc force-pushed the migrate-component-helper-app-components-form-credential-library-index branch from 77a3220 to 52706ea Compare October 6, 2025 15:12
@hashicc hashicc force-pushed the migrate-component-helper-app-components-form-credential-library-index branch from 52706ea to 5c93c8b Compare October 6, 2025 20:29
lisbet-alvarez
lisbet-alvarez approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hashicc hashicc force-pushed the migrate-component-helper-app-components-form-credential-library-index branch from 5c93c8b to 0cc246e Compare October 7, 2025 01:24
@hashicc hashicc force-pushed the migrate-component-helper-app-components-form-credential-library-index branch from 0cc246e to 2b8e988 Compare October 7, 2025 14:18
@hashicc hashicc changed the title Migrate component helper app components form credential library index Migrate away from component helper in credential library form component Oct 7, 2025
@hashicc hashicc merged commit 0bd152e into main Oct 7, 2025
14 checks passed
@hashicc hashicc deleted the migrate-component-helper-app-components-form-credential-library-index branch October 7, 2025 17:40
DhariniJeeva pushed a commit that referenced this pull request Oct 9, 2025
@hashicc @DhariniJeeva
Migrate away from component helper in credential library form compone…
6c50227 
…nt (#3013)

* refactor: 💡 migrate away from component helper for cred library form

* Add missing copyright headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZedLi ZedLi ZedLi approved these changes

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

@lisbet-alvarez lisbet-alvarez lisbet-alvarez approved these changes

Assignees

No one assigned

Labels

admin ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hashicc @ZedLi @DhariniJeeva @lisbet-alvarez