Use joins with filters #3010
Open
Use joins with filters #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ZedLi
force-pushed
the
use-joins-with-filters
branch
from
80b7833 to
73e3257
Compare
ZedLi
force-pushed
the
use-sqlite-for-filters-session-recording
branch
from
db6b30a to
5729b0a
Compare
ZedLi
force-pushed
the
use-joins-with-filters
branch
from
73e3257 to
0903065
Compare
ZedLi
force-pushed
the
use-sqlite-for-filters-session-recording
branch
from
5729b0a to
ae6ba6f
Compare
ZedLi
force-pushed
the
use-joins-with-filters
branch
from
0903065 to
700e37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for joins with filters. Added an example using the targets table where I join with sessions to grab the active sessions instead of passing in a list of target IDs from the sessions. This removes the need to grab and return all sessions which can be very slow (and even cause browser errors) with big enough data sets and is where the bulk of the time loading is spent if there's a lot of data.
Screenshots (if appropriate)
How to Test
Try using the active sessions filter on the targets page.
Checklist
[ ] I have added before and after screenshots for UI changes[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have addeda11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.