Skip to content

Conversation

@venusang
Copy link

@venusang venusang commented Aug 27, 2025

Description

This updates the input fields on the User details page so that they are readonly instead of disabled. Additionally it updates the form submit button so that it is more descriptive and also includes an aria-label.

🎟️ FE-112

Screenshots (if appropriate)

fe-112-before-after

How to Test

Navigate to a User in the Users list. Verify that the input fields are readonly (you should be able to highlight the text with your mouse) and that the submit button reflects the text changes shown in the after screenshot.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

This adds edit user details translations so the User detail form submit
button is a11y compliant

✅ Closes: FE-112
Per a11y audit, this changes the input fields to readonly instead of
disabled. It also updates the submit button text so that it is context
based and has an aria-label for screenreaders.

✅ Closes: FE-112
@venusang venusang requested a review from a team as a code owner August 27, 2025 00:00
@vercel
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
boundary-ui Ready Ready Preview Comment Aug 27, 2025 5:58pm
boundary-ui-desktop Ready Ready Preview Comment Aug 27, 2025 5:58pm

Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking off these changes!

This moves the User detail action translation to resources/en-us.yaml
since it is specific to the user resource and is not a generic form
action.

✅ Closes: FE-112
@venusang
Copy link
Author

Closing this and opened #2977 so that it does not have a forked branch.

@venusang venusang closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants